android / android/nowinandroid

[Bug]: Splashscreen theme doesn't change after switching the color theme

Open
#633 7 comments 0 reactions 0 assignees View on GitHub
bug good first issue help wanted
Dominant language
Kotlin
Stars
21.8k
Forks
4.6k
Avg merge
19h 20m
Merged PRs (30d)
2

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Is there a StackOverflow question about this issue?

- [X] I have searched StackOverflow

### What happened?

Changing the theme from the application settings does not update the theme used on the splash screen.

Steps to reproduce:
* When using a light system theme
* Tap on the settings icon and set the application theme to dark
* Close the application, start it again (with the cold start) and note the splash screen

Expected result:
Splash screen should be in dark mode

Actual result:
Light splash screen switches to a dark screen of the application.

I think that UiModeManager#setApplicationNightMode should also be called on saving the theme settings as it is described in ["Implement dark theme"](https://developer.android.com/develop/ui/views/theming/darktheme#change-themes)

### Relevant logcat output

_No response_

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Research direction

Start at the application settings path that saves the selected theme and compare it with Android's UiModeManager#setApplicationNightMode guidance linked in the issue. Reproduce the cold-start sequence with a light system theme and a saved dark application theme. Done means the splash screen uses dark mode consistently with the application after restart.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.