android / android/nowinandroid

Interests and Topic feature modules should be merged

Open
#1,414 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
21.8k
Forks
4.6k
Avg merge
19h 20m
Merged PRs (30d)
2

Description

Previously we had an authors module so the module structure was:

- interests
- authors
- topics

Now that we no longer have authors, the nested structure adds complexity for no benefit, making it especially difficult to understand the navigation graph. Suggest merging `:topics` into `:interests` (whilst keeping the `Topic` model).

This would enable `InterestsListDetailScreen` which is currently in the `:app` module to be moved into the feature module.

Contributor guide

Open the contributing guide

Research direction

Start by tracing the :interests, :topics, and :app modules, including InterestsListDetailScreen and the Topic model, to understand the current navigation graph and module dependencies. Done means merging :topics into :interests while keeping Topic and moving InterestsListDetailScreen out of :app without breaking the feature structure.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.