android / android/nowinandroid
[Bug]: CI allows merging PRs with failing checks
- Dominant language
- Kotlin
- Stars
- 21.8k
- Forks
- 4.6k
- Avg merge
- 19h 20m
- Merged PRs (30d)
- 2
Description
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Is there a StackOverflow question about this issue?
- [X] I have searched StackOverflow
### What happened?
#### Initial push, all checks are run:

#### Because commit contains UI changes, an automated commit `🤖 Updates screenshots` is added, resetting all checks but `cla/google`

#### Resulting in `✅ All checks have passed`
----
For reference, this is what happened in #942 [breaking the main branch after merge](https://github.com/android/nowinandroid/issues/1041).
And #1044 for a simpler example.
### Relevant logcat output
_No response_
### Code of Conduct
- [X] I agree to follow this project's Code of Conduct
Contributor guide
Research direction
Compare the check results in the screenshots before and after the automated “🤖 Updates screenshots” commit, using #942/#1041 and #1044 as related examples. Trace the CI configuration that handles these commits and verify that stale or missing checks cannot produce a passing merge result; done when a failing check still blocks merging.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100