android / android/nowinandroid

[Bug]: CI allows merging PRs with failing checks

Open
#1,045 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Kotlin
Stars
21.8k
Forks
4.6k
Avg merge
19h 20m
Merged PRs (30d)
2

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Is there a StackOverflow question about this issue?

- [X] I have searched StackOverflow

### What happened?

#### Initial push, all checks are run:

![Screenshot 2023-11-18 093425](https://github.com/android/nowinandroid/assets/1921278/f040c588-fd64-4ba0-804d-046df477ec75)

#### Because commit contains UI changes, an automated commit `🤖 Updates screenshots` is added, resetting all checks but `cla/google`

![image](https://github.com/android/nowinandroid/assets/1921278/33f46339-da77-41fd-aa7e-96f38d84826c)

#### Resulting in `✅ All checks have passed`

----

For reference, this is what happened in #942 [breaking the main branch after merge](https://github.com/android/nowinandroid/issues/1041).
And #1044 for a simpler example.

### Relevant logcat output

_No response_

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Research direction

Compare the check results in the screenshots before and after the automated “🤖 Updates screenshots” commit, using #942/#1041 and #1044 as related examples. Trace the CI configuration that handles these commits and verify that stale or missing checks cannot produce a passing merge result; done when a failing check still blocks merging.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.