android / android/codelab-exoplayer-intro

Assigning playWhenReady wrongly in codelab-00

Open
#73 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Kotlin
Stars
235
Forks
129
PR merge metrics
No merged PRs in 30d

Description

In PlayerActivity.releasePlayer(), inside player?.run block playWhenReady is assigning wrong:

// Inside run block 'this' refer to player and current context is also player
// so we can use:
// this@PlayerActivity.playWhenReady = playWhenReady
// instead of below line.
**playWhenReady = this.playWhenReady**

Contributor guide

Open the contributing guide

Research direction

Start in codelab-00 at PlayerActivity.releasePlayer(), specifically the player?.run block and its playWhenReady assignment. Check the receiver and enclosing activity reference, then verify that the saved player state is assigned to the intended property; done means the assignment matches the issue's requested behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.