android / android/codelab-exoplayer-intro

Specify AudioAttributes for all playback scenarios

Open
#41 1 comment 0 reactions 1 assignee Claimed by @dturner View on GitHub
Dominant language
Kotlin
Stars
235
Forks
129
PR merge metrics
No merged PRs in 30d

Description

From Andrew:

> With audio focus handling, it's now possible for the player to have playWhenReady true and player state READY, but not actually to be playing: https://github.com/google/ExoPlayer/blob/r2.10.5/library/core/src/main/java/com/google/android/exoplayer2/Player.java#L623

> I think it's okay to leave this as it is because audio focus handling isn't enabled in this tutorial, but on the other hand the new method is quite easy to use so I wonder if we should be directing people to that. (Side note: I think it's also good practice to specify AudioAttributes for all playbacks, but the tutorial doesn't do that at the moment; if it did, then we'd also need to pass a boolean setting whether to enable/disable audio focus handling as ExoPlayer has a combined setter for both.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.