android / android/codelab-android-dynamic-features

minifyWithR8 issue with Dynamic feature module, release build

Open
#39 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
129
Forks
51
PR merge metrics
No merged PRs in 30d

Description

Hi,

I am working on a dynamic feature module for the first time.

below is my project configuration:

### **mobile.gradle //main app**

`dynamicFeatures = [':alt_acco']`

**### alt_acco.gradle. feature module**

`apply plugin: 'com.android.dynamic-feature'

android {
compileSdkVersion rootProject.ext.compileSdkVersion
buildToolsVersion rootProject.ext.buildToolsVersion

lintOptions {
checkReleaseBuilds false
// Or, if you prefer, you can continue to check for errors in release builds,
// but continue the build even when errors are found:
abortOnError false
tasks.lint.enabled = false
}

defaultConfig {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles 'consumer-rules.pro'
missingDimensionStrategy 'react-native-camera', 'general'
}

compileOptions {
targetCompatibility 1.8
sourceCompatibility 1.8
incremental true
}

buildTypes {
release {
}

releaseStaging {
matchingFallbacks = ['release']
}

debug {
}
}

productFlavors {
flavorDimensions "type"
standard {
dimension "type"
buildConfigField 'Boolean', 'Automation', 'false'
}
standardBasicOptimized {
dimension "type"
buildConfigField 'Boolean', 'Automation', 'false'
}
standard_charles {
dimension "type"
buildConfigField 'Boolean', 'Automation', 'false'
}
automation_charles {
dimension "type"
buildConfigField 'Boolean', 'Automation', 'true'
}
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}

dataBinding {
enabled = true
}
}

dependencies {
// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation platform('com.google.firebase:firebase-bom:28.2.1')

// Firestore (Java)
implementation 'com.google.firebase:firebase-firestore'

// Firestore (Kotlin)
implementation 'com.google.firebase:firebase-firestore-ktx'

// Google Play services
implementation project(path: ':mobile')
}
`

settings.gradle

`include ':alt_acco'

`

I am making a release build and error i am getting is as follows:

`Task :mobile:minifyStandardBasicOptimizedReleaseWithR8
/root/.gradle/caches/transforms-3/1169397e4788b932b8c86a71183af227/transformed/jetified-time4j-android-4.2-2018i/proguard.txt:1:1-27: R8: Ignoring option: -useuniqueclassmembernames
/opt/jenkins/workspace/APP-Android-Verify/mobile/build/intermediates/module_and_runtime_deps_classes/standardBasicOptimizedRelease/base.jar: R8: Type com.google.common.util.concurrent.ListenableFuture is defined multiple times: /opt/jenkins/workspace/APP-Android-Verify/mobile/build/intermediates/module_and_runtime_deps_classes/standardBasicOptimizedRelease/base.jar:com/google/common/util/concurrent/ListenableFuture.class, /opt/jenkins/workspace/APP-Android-Verify/alt_acco/build/intermediates/module_and_runtime_deps_classes/standardBasicOptimizedRelease/feature-alt_acco.jar:com/google/common/util/concurrent/ListenableFuture.class
Task :mobile:minifyStandardBasicOptimizedReleaseWithR8 FAILED
FAILURE: Build failed with an exception.
What went wrong:
Execution failed for task ':mobile:minifyStandardBasicOptimizedReleaseWithR8'.
com.android.tools.r8.CompilationFailedException: Compilation failed to complete, origin: /opt/jenkins/workspace/APP-Android-Verify/mobile/build/intermediates/module_and_runtime_deps_classes/standardBasicOptimizedRelease/base.jar:com/google/common/util/concurrent/ListenableFuture.class`

Help will be really appreciated.

Contributor guide

Open the contributing guide

Research direction

Start with mobile.gradle, alt_acco.gradle, and settings.gradle, then run the standardBasicOptimizedRelease build task shown in the report. Inspect why ListenableFuture appears in both base.jar and feature-alt_acco.jar; done means the release minification task completes without the duplicate-class failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, firebase
Domain
build-system, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.