android / android/codelab-android-compose
Unnecessary, obscure way to shuffle a list in the Advanced State and Side Effects codelab?
Open
- Dominant language
- Kotlin
- Stars
- 1.7k
- Forks
- 799
- PR merge metrics
- No merged PRs in 30d
Description
At the line linked below, `shuffled` given a `Random` whose seed is generated Randomly (which is not substantially different than not providing a Random at all). Why?
https://github.com/googlecodelabs/android-compose-codelabs/blob/37b4e639d3befcfd85885ba9cefceb26f8b32f5e/AdvancedStateAndSideEffectsCodelab/app/src/main/java/androidx/compose/samples/crane/home/MainViewModel.kt#L59
And if you want a number between 1 and 100, why shuffle a collection of 100 numbers rather than use `Random.nextInt (1,101)`?
Contributor guide
Assessment
This issue has not been assessed yet.