android / android/codelab-android-compose

Jetpack Compose Basics tutorial doesn't mention changing app theme

Open
#247 0 comments 0 reactions 1 assignee Claimed by @JolandaVerhoef View on GitHub
Dominant language
Kotlin
Stars
1.7k
Forks
799
PR merge metrics
No merged PRs in 30d

Description

The tutorial here implicitly depends on using a day/night theme in themes.xml: https://developer.android.com/codelabs/jetpack-compose-basics

For example, themes.xml in the solution contains this code:

```




<item name="windowActionBar">false</item>
<item name="windowNoTitle">true</item>

<style name="Theme.BasicsCodelab.PopupOverlay" parent="ThemeOverlay.AppCompat.Light" />
</resources>

```

However, creating a new Compose project with Android Studio results in this theme:

```
<resources>

<style name="Theme.BasicsCodelab" parent="android:Theme.Material.Light.NoActionBar">
<item name="android:statusBarColor">@color/purple_700</item>

```

This leads to differences in expected behavior and actual behavior from following the tutorial. For example, components won't display a dark background without wrapping them in a compose Surface. The system bar also won't follow dark mode and there may also be differences with system dialogs and other components.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.