android / android/architecture-samples

SwipeRefreshLayout.setOnRefreshListener should force update

Open
#610 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
45.8k
Forks
11.9k
PR merge metrics
No merged PRs in 30d

Description

on `todo-mvp-kotlin` and `todo-mvp-rxjava` the TasksFragment's `SwipeRefreshLayout.setOnRefreshListener` call always has ` { presenter.loadTasks(forceUpdate = false) }`

I'm wondering if I'm misunderstanding the code but wouldn't you expect a "pull to refresh" action to query the network?

Contributor guide

Open the contributing guide

Research direction

Inspect TasksFragment in the todo-mvp-kotlin and todo-mvp-rxjava samples, starting at each SwipeRefreshLayout.setOnRefreshListener call. Verify how the listener passes forceUpdate to presenter.loadTasks and confirm that pull-to-refresh performs the intended network refresh in both samples.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.