android / android/architecture-samples

todo‑mvp not sure this is intentional or something else

Open
#589 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Kotlin
Stars
45.8k
Forks
11.9k
PR merge metrics
No merged PRs in 30d

Description

Notice 2 onClick() callbacks, the mPresenter.addNewTask() is basicly call view#showAddTask().
Should we call mPresenter.addNewTask() in these 2 callbacks or I'm missing something?

https://github.com/googlesamples/android-architecture/blob/30f7c5a16bb0854e003530e81403e922e745d311/todoapp/app/src/main/java/com/example/android/architecture/blueprints/todoapp/tasks/TasksFragment.java#L120-L137

https://github.com/googlesamples/android-architecture/blob/30f7c5a16bb0854e003530e81403e922e745d311/todoapp/app/src/main/java/com/example/android/architecture/blueprints/todoapp/tasks/TasksPresenter.java#L185-L188

Contributor guide

Open the contributing guide

Research direction

Start by reading the two onClick() callbacks in todoapp/app/src/main/java/com/example/android/architecture/blueprints/todoapp/tasks/TasksFragment.java at lines 120-137, then compare them with mPresenter.addNewTask() in TasksPresenter.java at lines 185-188. Determine whether the callbacks should invoke that presenter method and confirm the add-task flow behaves as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.