android / android/architecture-samples
[todo‑mvp‑rxjava] What is the purpose of setLoadingIndicator() need to check getView() is null or not
Open
- Dominant language
- Kotlin
- Stars
- 45.8k
- Forks
- 11.9k
- PR merge metrics
- No merged PRs in 30d
Description
I guess it can prevent the async call setLoadingIndicator() when view was destroy.
But in `todo‑mvp‑rxjava`, the async call would be dispose when view on pause.
Is it necessary to check view is null or not ?
Contributor guide
Research direction
Locate the setLoadingIndicator() implementation in the todo-mvp-rxjava sample and inspect how it uses getView(). Trace the asynchronous call's disposal during the view's pause lifecycle, then determine whether the null check is redundant and record the rationale or required change in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100