android / android/architecture-samples
[todo-mvp] Change setLoadingIndicator to two separate functions
Open
- Dominant language
- Kotlin
- Stars
- 45.8k
- Forks
- 11.9k
- PR merge metrics
- No merged PRs in 30d
Description
According to SOLID principles, a function should have only a single responsibility, but the `setLoadingIndicator()` function has two responsibilities, showing and hiding. I want to break it into two functions such as `showLoadingIndicator()` and `hideLoadingIndicator()`.
Contributor guide
Research direction
Search the repository for setLoadingIndicator() and inspect its callers to understand the existing show and hide behavior. Split those responsibilities into separate showLoadingIndicator() and hideLoadingIndicator() functions, then verify that all callers still produce the expected loading-indicator behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100