android / android/architecture-samples

TODO-MVP: getTaskWithId could return dirty task

Open
#528 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
45.8k
Forks
11.9k
PR merge metrics
No merged PRs in 30d

Description

Where is check `mCacheIsDirty` or why is it not necessary?
```
@Nullable
private Task getTaskWithId(@NonNull String id) {
checkNotNull(id);
if (mCachedTasks == null || mCachedTasks.isEmpty()) {
return null;
} else {
return mCachedTasks.get(id);
}
}
```

Contributor guide

Open the contributing guide

Research direction

Start by tracing the private getTaskWithId(String id) method and the mCachedTasks and mCacheIsDirty state it references. Determine whether a dirty cache can return an outdated Task, then identify the existing test or call path that demonstrates the expected behavior. Done means the cache-dirty behavior is resolved or explicitly shown to be unnecessary.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.