android / android/architecture-samples

[todo-mvvm-rx]Having a reference to Context in ResourceProviders might leak memory?

Open
#500 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
45.8k
Forks
11.9k
PR merge metrics
No merged PRs in 30d

Description

Hi @florina-muntenescu I noticed that in [ResourceProvider](https://github.com/googlesamples/android-architecture/blob/dev-todo-mvvm-rxjava/todoapp/app/src/main/java/com/example/android/architecture/blueprints/todoapp/util/providers/ResourceProvider.java) there's a reference to the context. Will this be leaking memory? or how is this handled? should it be handled at all?

Contributor guide

Open the contributing guide

Research direction

Open the linked ResourceProvider.java file first and inspect how its Context reference is obtained and used. Trace the reference through the todo-mvvm-rxjava sample; done requires a clear, maintainer-agreed conclusion about whether the lifecycle can leak memory and what resolution, if any, is needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile-dev
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.