android / android/architecture-samples

[all] Proguard test rules

Open
#306 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Kotlin
Stars
45.8k
Forks
11.9k
PR merge metrics
No merged PRs in 30d

Description

Hello,

When looking at the proguard rules I noticed that the `proguard-rules.pro` file contains a rules which keeps all the app classes and methods. Because some methods are only called from tests this is of course required but for release builds this seems unneeded to me. Is there a specific reason for this rule to be in the `proguard-rules.pro` file and not in the `proguardTest-rules.pro` file?

Contributor guide

Open the contributing guide

Research direction

Compare the rules in proguard-rules.pro with the proposed proguardTest-rules.pro location, and determine why the app classes and methods are currently kept globally. Verify the effect on test and release builds; done means test-only rules are scoped appropriately without breaking either build.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
build-system, mobile
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.