andrewrk / andrewrk/groovebasin
client: avoid blocking dialogs
Open
enhancement
- Dominant language
- JavaScript
- Stars
- 2k
- Forks
- 119
- PR merge metrics
- No merged PRs in 30d
Description
alert and confirm block the only thread. This thread is also used for audio decoding and playback. This means that while the user is prompted to confirm deletion, audio playback freezes. Oops.
We still want to confirm but we need to do it non-blocking.
When implementing this, be very careful to not introduce a bug where changing the selection with the dialog still open would cause the wrong songs to be deleted.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.