andrewdyer / andrewdyer/command-bus
Handler validation allows objects without a real handle method
Open
- Dominant language
- PHP
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
the `CommandBus::register()` uses `is_callable([$handler, 'handle'])` to validate that a handler has a public `handle()` method. However, is_callable() returns `true` for any object implementing `__call()`, even if no concrete `handle()` method exists — contradicting the exception message and documented contract.
Fix: Replace the `is_callable()` check with `method_exists()` + `ReflectionMethod::isPublic():`
```php
isPublic()) {
throw new InvalidArgumentException(...);
}
```
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.