andlabs / andlabs/libui

Bug of build libui by VS2017

Open
#267 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
10.9k
Forks
612
PR merge metrics
No merged PRs in 30d

Description

void runMenuEvent(WORD id, uiWindow *w)
{
uiMenu *m;
uiMenuItem *item;
size_t i, j;

// this isn't optimal, but it works, and it should be just fine for most cases
for (i = 0; i < len; i++) {
m = menus[i];
for (j = 0; j < m->len; j++) {
item = m->items[j];
if (item->id == id)
goto found;
}
}
// no match
implbug("unknown menu ID %hu in runMenuEvent()", id);

found:
// first toggle checkboxes, if any
if (item->type == typeCheckbox)
uiMenuItemSetChecked(item, !uiMenuItemChecked(item));

// then run the event
(*(item->onClicked))(item, w, item->onClickedData);
}

C4703 May use uninitialized local pointer variables"item"

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.