anchore / anchore/chronicle

Ignored PR in changelog

Open
#309 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
65
Forks
8
PR merge metrics
No merged PRs in 30d

Description

**What happened**:
When a PR closes an issue outside of the repo the accompanying PR is not included in the changelog:
https://github.com/anchore/stereoscope/pull/382

The commit was considered:
> [0000] DEBUG ├── de1c8e2565179839581b9c9fc91880be3a16f4ed

Linked to to a syft issue
> [0001] TRACE PR #382 filtered out: has linked issue that is still open: issue 3683

Claims to have also filtered it out for label reasons:
> [0001] TRACE PR #382 filtered out: has labels

**What you expected to happen**:
When a PR closes an issue outside of the repo the accompanying PR should be in the changelog.

Proposed fix: we should agnostically make certain that if we're filtering out a PR because it's linked to something that the issue in question that would take it's place is at least being considered (if not then we should keep it).

Contributor guide

Open the contributing guide

Research direction

Trace the filtering that produces the messages for PR #382, especially the linked-issue and label checks, and compare it with the changelog inclusion path. Use the linked Syft issue 3683 as the cross-repository case. Done means a PR closing an external issue is retained when the replacement issue is not being considered, without allowing the existing filters to hide it incorrectly.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, go
Domain
release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.