anc95 / anc95/ChatGPT-CodeReview

Code review will not fail automatically in case of issues

Open
#47 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
4.5k
Forks
461
PR merge metrics
No merged PRs in 30d

Description

image

For some reason, there was an issue with the review
and action didn't cancel until the 6-hour timeout had elapsed

@@ -6,6 +6,7 @@
import lombok.Getter;

import java.math.BigDecimal;
import java.math.RoundingMode;

@Getter
@Builder(access = AccessLevel.PRIVATE)
@@ -21,6 +22,8 @@ public class SubscriptionPlanDto {
    public static SubscriptionPlanDto NONE() {
        // TODO: 구독 없는 경우 어떻게 처리? (플로우)
        return SubscriptionPlanDto.builder()
                .planCode("")
                .price(BigDecimal.ZERO)
                .name("이용중인 서비스 없음")
                .isActive(false)
                .build();
@@ -34,7 +37,7 @@ public static SubscriptionPlanDto of(SubscriptionPlan plan) {
                .description(plan.getDescription())
                .planCode(plan.getPlanCode())
                .price(plan.getPrice())
                .priceIncludeVat(plan.getPrice().multiply(BigDecimal.valueOf(1.1)))
                .priceIncludeVat(plan.getPrice().multiply(BigDecimal.valueOf(1.1)).setScale(0, RoundingMode.FLOOR)) // 1원단위 절삭
                .isActive(plan.getIsActive())
                .build();
    }

This code that tried, just simple

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the code-review action entry point responsible for handling the shown review result and the six-hour timeout. Reproduce or inspect the reported failure path, then verify that an unsuccessful review causes the action to fail or cancel promptly instead of waiting for the timeout.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, javascript
Domain
ci-cd, devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.