anandthakker / anandthakker/doiuse

`mdn-text-decoration-shorthand` is incorrect and needs to be done something about it

Offen
#174 4 Kommentare 3 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
JavaScript
Sterne
1.3k
Forks
57
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Using `doiuse` in my project, I encountered the fact that when using the `text-decoration` rule I received an error message like `mdn-text-decoration-shorthand`. I read [mdn about `text-decoration`](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration) and realized that:

1. The check is not correct since the `text-decoration` property itself has been used since Chrome 1
2. Checking in general is not necessary, since each of the `text-decoration-...` properties has its own separate checking rules (that's not accurate)

image

I can do a PR with the edits, but I couldn’t come to the conclusion that it’s better: remove this check altogether or fix it so that it only works on declaration like `text-decoration-...: ...` . What do you think?

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.