amzn / amzn/smoke-framework

Package.swift does not contain all dependencies

Open
#62 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.5k
Forks
51
PR merge metrics
No merged PRs in 30d

Description

Some versions of swift package manager react badly to missing dependencies in the swift package file.

For example -

`SmokeHTTP1` uses `SmokeOperations` (here https://github.com/amzn/smoke-framework/blob/main/Sources/SmokeHTTP1/ChannelHTTP1ResponseHandler.swift#L21)

but there is no declared dependency (here https://github.com/amzn/smoke-framework/blob/db1332849a16575cb71426ccfbc2065d2f0c3352/Package.swift#L59-L65)

Contributor guide

Open the contributing guide

Research direction

Start in Package.swift, especially the dependency declarations around the referenced lines, and compare them with SmokeHTTP1's use of SmokeOperations in Sources/SmokeHTTP1/ChannelHTTP1ResponseHandler.swift. The work is done when the missing dependency is declared and Swift Package Manager accepts the package across affected versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.