ampproject / ampproject/meta-tsc

Cherry pick policy for third party only change

Open
#80 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
17
Forks
8
PR merge metrics
No merged PRs in 30d

Description

We encountered a scenario where a third party only change was requested to be cherry picked into AMP stable bundle (https://github.com/ampproject/amphtml/issues/37485) .It does not appear to follow the existing cherry pick policy due to its impact on amp core is minimal since it only affects that certain vendor.

Due to the fact that verifying such a vendor-specific change was not a lot of work as the core was unchanged. Should we adjust our cherry pick policy (https://github.com/ampproject/amphtml/blob/main/docs/contributing-code.md#cherry-picks) by allowing such changes to be cherry picked if it causes significant breakages for that vendor? We may say P0 on a vendor is also CP-eligible.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with docs/contributing-code.md#cherry-picks and review the referenced AMP issue 37485 for the vendor-specific case. Determine whether the cherry-pick policy should include vendor-level P0 breakages, then update the policy only after the proposed rule has been agreed by the Technical Steering Committee.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.