ampproject / ampproject/ampstart
[TRAVEL - Home] Bugs intro'd by fixes
- Dominant language
- HTML
- Stars
- 415
- Forks
- 147
- PR merge metrics
- No merged PRs in 30d
Description
Can @ericlindley-g , @mattludwig confirm these?
- [ ] container line for "email / sign up" is 1 px off. White is extending beyond container. [safari, ios 11.1.2]
- [ ] tiny weird white space, exacerbated in landscape view [safari, ios 11.1.2] - its possible this isnt worth fixing - i leave it to @camelburrito to decide. right now it looks way better than it did!!
- [ ] hero image extends past the container - is that new or was already like that? OK if it was already like that. i think its a know amp bug.
- [ ] Mobile scrolling is buggy / jumpy [safari, ios 11.1.2, portrait] - i actually cant repo upon refresh but just want to triple check
thanks!! otherwise GTG for me. just need @ericlindley-g and @mattludwig to confirm its ready!!!
cc/ @camelburrito
Contributor guide
Research direction
Start by reproducing the listed Home-page issues in Safari on iOS 11.1.2, checking portrait and landscape views and comparing the attached screenshots. Verify the email/sign-up container, white space, hero image overflow, and scrolling behavior; done means each item is either fixed or confirmed as an existing AMP issue and the page is ready for review.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100