ampproject / ampproject/amppackager
Use a custom logger
- Dominant language
- Go
- Stars
- 141
- Forks
- 46
- PR merge metrics
- No merged PRs in 30d
Description
At the very least, call https://golang.org/pkg/log/#New from main and pass to the handler constructors. This way we can make our tests less noisy.
Maybe upgrade to https://godoc.org/github.com/golang/glog or https://github.com/op/go-logging or https://github.com/juju/loggo or something, though https://dave.cheney.net/2015/11/05/lets-talk-about-logging argues against it.
Contributor guide
Research direction
Start at main and trace the handler constructors to see how logging is currently wired. Use Go's log.New as described in the issue, pass the logger into the handlers, and verify that the tests are less noisy; optional logging-library upgrades are separate possibilities.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100