ampproject / ampproject/amppackager

Facing issue after update certificate

Open
#652 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
141
Forks
46
PR merge metrics
No merged PRs in 30d

Description

We just updating certificate which will be expired. But somehow after doing that, we facing issue like message below:

```sh
2022/07/14 16:56:08 Updating cert if necessary
2022/07/14 16:56:08 Certfetcher is not set, skipping cert updates. Checking cert on disk if updated.
2022/07/14 16:56:08 Updating OCSP; none cached yet.
2022/07/14 16:56:08 Updating OCSP; none cached yet.
2022/07/14 16:56:08 Updating OCSP; none cached yet.
2022/07/14 16:56:08 OCSP nextUpdate 2022-07-21 06:27:00 +0000 UTC too far ahead of thisUpdate 2022-07-14 00:00:00 +0000 UTC
```

Based on the code the message is coming from this code below:

https://github.com/ampproject/amppackager/blob/9cd448f3172d9dd3b0370cd48a12f3ba52b9b289/packager/certcache/certcache.go#L673

Is there any clue why this issue appears ?

Contributor guide

Open the contributing guide

Research direction

Start in packager/certcache/certcache.go around line 673, where the reported OCSP message is emitted. Trace the certificate update and OCSP validation path, then inspect or add focused tests for the certificate scenario; done means the cause is identified and the expected handling is covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.