ampproject / ampproject/amppackager

protoc-gen-go/generator deprecation

Open
#482 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
141
Forks
46
PR merge metrics
No merged PRs in 30d

Description

When building cmd/amppkg with `-tags dns01` and running, we get the following warning msg on stdout:

```
WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated.
A future release of golang/protobuf will delete this package,
which has long been excluded from the compatibility promise.
```

AFAIK, we don't use this directly, so it's some indirect usage (lego?).

Contributor guide

Open the contributing guide

Research direction

Reproduce the warning by building and running cmd/amppkg with the dns01 tag, then trace which dependency brings in github.com/golang/protobuf/protoc-gen-go/generator, possibly through lego. Done means the indirect dependency is updated or removed and the warning no longer appears on stdout.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.