ampproject / ampproject/amppackager
Refactor CertCache.renewed* fields into a sub-struct
- Dominant language
- Go
- Stars
- 141
- Forks
- 46
- PR merge metrics
- No merged PRs in 30d
Description
Currently, CertCache has a bunch of fields named foo and renewedFoo, to store info about the old and new certificate (for ACME renewal). Two things:
- It's missing renewedOCSP fields, as reported in #399.
- It would be nice to refactor all these fields into a struct CertInfo with some methods, and then we could just have two CertInfos, and hopefully reduce some code duplication.
Contributor guide
Research direction
Start by locating CertCache and cataloguing its existing certificate and renewed* fields, then review issue #399 for the missing renewedOCSP context. Define the CertInfo boundary and methods before consolidating the old and new certificate data; done means both CertInfos cover the existing fields, including OCSP, without duplicated handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100