ampproject / ampproject/amppackager
Add more tests to accept_test.go
Open
fixit
- Dominant language
- Go
- Stars
- 141
- Forks
- 46
- PR merge metrics
- No merged PRs in 30d
Description
Add all the tests in cl/243547227 that are missing from [`accept_test.go`](https://github.com/ampproject/amppackager/blob/releases/packager/accept/accept_test.go). Maybe require putting some of those on the wrong side, as #240 is still open.
Contributor guide
Research direction
Start by reading packager/accept/accept_test.go and compare it with the tests referenced in cl/243547227. Review issue #240 to understand which cases may need to be placed on the wrong side. Done means the missing tests are added and the accept test suite covers those cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100