ampproject / ampproject/amppackager

Figure out how to handle Trailers

Open
#194 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
141
Forks
46
PR merge metrics
No merged PRs in 30d

Description

The signer currently fetches without a `TE` header so backend servers shouldn't be sending these. If we see one in spite of that, we should probably 502.

In the future, the SXG spec may end up banning chunked transfer-encoding (see WICG/webpackage#336), so it's probably not worth adding any more support than that.

Contributor guide

Open the contributing guide

Research direction

Start at the signer entry point and trace how HTTP response trailers are observed when fetching from backend servers. Check the existing SXG and HTTP handling before deciding how an unexpected trailer should fail; the stated completion behavior is a 502 response, and no file or test is named.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.