ampproject / ampproject/amppackager

Generate conditional ETag from inner conditional response headers

Open
#112 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
141
Forks
46
PR merge metrics
No merged PRs in 30d

Description

Copy `ETag` and `Last-Modified` from the `fetchResp` to the outer `resp`. This enables clients to transparently take advantage of #34 without having to understand the SXG format.

Contributor guide

Open the contributing guide

Research direction

Locate where the inner fetchResp and outer resp are created and their response headers are handled. Start by tracing that response path, then verify that ETag and Last-Modified from fetchResp appear on resp for conditional responses; the issue is done when clients can use those headers without understanding SXG.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.