ampproject / ampproject/amphtml

Integration test not working on circle amp-youtube

Open
#40,181 0 comments 0 reactions 0 assignees View on GitHub
Type: Bug
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

### Description

On CircleCI, amp-youtube integration tests are not working 100% of time (test/integration/test-video-players.js). Likely caused by some network differences. It has been disabled.

### Reproduction Steps

Run `amp integration`

### Relevant Logs

_No response_

### Browser(s) Affected

_No response_

### OS(s) Affected

_No response_

### Device(s) Affected

_No response_

### AMP Version Affected

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with test/integration/test-video-players.js and run `amp integration` to reproduce the intermittent amp-youtube failure on CircleCI. Investigate the reported network-related behavior and determine what is needed for the test to run reliably, with the test enabled and passing consistently as the completion criterion.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.