ampproject / ampproject/amphtml

Fix browser frame management for amp-story

Open
#38,595 2 comments 1 reaction 0 assignees View on GitHub
P2: Soon Stale Type: Bug WG: stories
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

### Description

Stories has been running into multiple story page navigation issues recently which was first reported in https://github.com/ampproject/amphtml/issues/38531. We have implemented quick workarounds as of now since a proper fix will take a bit of time to refactor the frame management code.

link to workaround https://github.com/ampproject/amphtml/pull/38576.

### Reproduction Steps

https://github.com/ampproject/amphtml/issues/38531

### Relevant Logs

_No response_

### Browser(s) Affected

_No response_

### OS(s) Affected

_No response_

### Device(s) Affected

_No response_

### AMP Version Affected

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the navigation problem described in issue 38531 and compare it with the workaround in pull request 38576. Then inspect the amp-story frame management code and reproduce the reported story page navigation issue. Done means the underlying frame management is corrected rather than relying on the workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.