ampproject / ampproject/amphtml
amp-story-shopping shopping breaks when the page id name is 'activeProductData'
Open
Component: amp-story-shopping
P3: When Possible
Stale
Type: Bug
WG: stories
- Dominant language
- JavaScript
- Stars
- 14.9k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
### Description
amp-story-shopping shopping breaks when the page id name is 'activeProductData'
### Reproduction Steps
Make the page id in an amp-story-shopping component 'activeProductData'.
Contributor guide
Research direction
Reproduce the failure by setting an amp-story-shopping page id to "activeProductData", then trace the component's handling of page ids and shopping data to identify the collision. Add a regression test covering this page id and verify that amp-story-shopping continues to work with it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100