ampproject / ampproject/amphtml
[amp-vimeo] New Vimeo 'h' parameter gets encoded
- Dominant language
- JavaScript
- Stars
- 14.9k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
### Description
Vimeo have added a new parameter to their embed code which is required for video identification. When this is passed to the amp-video element as part of the `data-videoid` it gets encoded.
e.g. html containing ``````
will be rendered as ``````
which is not recognised as a correct url
### Reproduction Steps
Create a new Vimeo video (must be new, as only new videos add the h param)
Copy the video id from the embed code (including the h param part)
Use this video id as the data-videoid for an amp-vimeo component
Video will not render due to encoding
### Relevant Logs
_No response_
### Browser(s) Affected
_No response_
### OS(s) Affected
_No response_
### Device(s) Affected
_No response_
### AMP Version Affected
_No response_
Contributor guide
Research direction
Start at the amp-vimeo component entry point and trace how data-videoid becomes the iframe src. Reproduce the issue with a Vimeo URL containing the h parameter, then verify that the rendered iframe preserves the URL and its query delimiter instead of encoding the full URL.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100