ampproject / ampproject/amphtml
[Story cleanup] `[desktop]` attr and `i-amphtml-story-desktop-fullbleed` are the same
Open
P3: When Possible
Stale
Type: Refactoring
WG: stories
- Dominant language
- JavaScript
- Stars
- 14.9k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
### Description
On fullbleed stories we use an attribute `[desktop]` and class `.i-amphtml-story-desktop-fullbleed` to mark the same thing, one of them can be removed and replace the CSS with the other.
https://github.com/ampproject/amphtml/blob/main/extensions/amp-story/1.0/amp-story.js#L1642
Contributor guide
Research direction
Start at extensions/amp-story/1.0/amp-story.js around line 1642, then search for references to the [desktop] attribute and .i-amphtml-story-desktop-fullbleed class. Determine which marker to retain and update the related CSS so fullbleed stories use only that marker; done means the duplicate marker is removed without changing fullbleed behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100