ampproject / ampproject/amphtml

[amp-base-carousel:1.0] amp-base-carousel prevents touchmove vertical scroll even with orientation=horizontal set

Open
#37,085 7 comments 0 reactions 1 assignee Claimed by @alanorozco View on GitHub
Type: Bug WG: components
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

### Description

The amp-base-carousel component prevents the vertical scroll touchmove scroll gesture to propagate.

This is not ideal because users would not be able to scroll the page vertically if the gesture started from a component part of the amp-base-carousel structure.

### Reproduction Steps

- browse any amp-base-carousel 1.0 example in Bento or AMP mode
- try to scroll vertically on the page by touching the image.

- expected: the page would scroll
- result: the page doesn't scroll. I guess there is a too strong preventDefault applied on events here.

### Relevant Logs

_No response_

### Browser(s) Affected

_No response_

### OS(s) Affected

_No response_

### Device(s) Affected

_No response_

### AMP Version Affected

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.