Cache wrongly edit cta-image if "none" in page-outlink

Open

#36,909 opened on Nov 12, 2021 1 comment 0 reactions 1 assignee Claimed by @processprocess View on GitHub

Stale Type: Bug WG: stories

Dominant language: JavaScript
Stars: 14.9k
Forks: 4.1k
PR merge metrics: No merged PRs in 30d

Description

### Description

When giving cta-image="none" to a amp-story-page-outlink, the cache is adding the story URL before none which cause display issue.

### Reproduction Steps

Non cached story:
![image](https://user-images.githubusercontent.com/21277631/141447153-a9333921-0277-4a83-acc3-c373dab6e733.png)
![image](https://user-images.githubusercontent.com/21277631/141447111-56d013c0-9555-4aa1-8f61-fd580646d7bf.png)
https://join-test.my.join-stories.com/bug-cache-outlink-image-N_2FWf1/

Cached story:
![image](https://user-images.githubusercontent.com/21277631/141447344-84f35920-4b4f-463a-82ea-fdb31a85027b.png)
![image](https://user-images.githubusercontent.com/21277631/141447227-8db4abc7-1b0a-4b38-a689-7d2c08ed8c87.png)
https://9jc7l.csb.app/

### Relevant Logs

_No response_

### Browser(s) Affected

_No response_

### OS(s) Affected

_No response_

### Device(s) Affected

_No response_

### AMP Version Affected

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Cache wrongly edit cta-image if "none" in page-outlink

Description

Contributor guide

Assessment

Get new issues in your inbox