ampproject / ampproject/amphtml

🐛[story-ads] the pause button should not show

Open
#36,819 3 comments 0 reactions 0 assignees View on GitHub
Component: amp-story-auto-ads P2: Soon Stale Type: Bug
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

### Description

The pause button from the parent story currently shows when ads are showing. We should hide it
![image](https://user-images.githubusercontent.com/16087874/140589334-6bc46cb0-70cf-45bb-b20a-459abaa0a837.png)

### Reproduction Steps

Click through this story in desktop mode until ads are showing.
https://www.humppy.com/web-stories/7-in-the-ring-so-did-ranbir-alia-get-engaged/

### Relevant Logs

_No response_

### Browser(s) Affected

_No response_

### OS(s) Affected

_No response_

### Device(s) Affected

_No response_

### AMP Version Affected

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in the linked web story in desktop mode and inspect the story ads and parent-story pause-button behavior. Done means the pause button is hidden while ads are showing, without changing its behavior outside ad playback.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.