ampproject / ampproject/amphtml

🎥 [story-ads] respect video duration from ads

Open
#36,817 1 comment 0 reactions 1 assignee Claimed by @calebcordry View on GitHub
Component: amp-story-auto-ads P1: High Priority Stale
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

### Description

As we look to enable auto-advance more generally we should make sure videos ads duration are respected. To limit abuse we will set the `auto-advance = min(15s, videoDuration)`

This can be in 2 parts
1. FIE support -- We have direct access to video element
2. Inabox support -- We will need the inabox runtime to postMessage the story. The story will need to listen for this message and respond by setting the limit.

### Reproduction Steps

n/a

### Relevant Logs

_No response_

### Browser(s) Affected

_No response_

### OS(s) Affected

_No response_

### Device(s) Affected

_No response_

### AMP Version Affected

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.