ampproject / ampproject/amphtml
FR: wait until item has loaded before advancing
- Dominant language
- JavaScript
- Stars
- 14.9k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
### Description
Certain components like ``, ``, and `` have the capability to automatically advance through items on a timer. For certain combinations of network, cpu, and timer intervals, it is possible that we transition items even before the current one has finished loading.
Each of these components should ensure the subresources within a slide (i.e. images) have loaded before advancing. Otherwise it is poor for both UX and web-vitals. I don't know whether or not we already do this, or if there are more components that can benefit from this change. Hopefully folks on @ampproject/wg-components and @ampproject/wg-stories can help me out.
- [ ] amp-story
- [ ] amp-base-carousel
- [ ] amp-carousel
---
Related: https://bugs.chromium.org/p/chromium/issues/detail?id=1249622
Contributor guide
Research direction
Start by locating the implementations and timer-based advancement paths for amp-story, amp-base-carousel, and amp-carousel. Check how each component observes slide subresource loading before transitioning. Done means the three listed components wait for their current slide's subresources to load before automatic advancement, with behavior verified for each component.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100