ampproject / ampproject/amphtml

Ads no signing throwing

Open
#35,708 1 comment 0 reactions 1 assignee Claimed by @calebcordry View on GitHub
Stale Type: Bug
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

### Description

```
ERROR: '[amp-a4a] TypeError: amp-a4a: doubleclick: httpResponse.clone is not a function'
The test "amp-ad-network-doubleclick-impl #multi-size amp creative - should force iframe to match size of creative" resulted in a call to console.error. (See above line.)
⤷ If the error is not expected, fix the code that generated the error.
⤷ If the error is expected (and synchronous), use the following pattern to wrap the test code that generated the error:
'allowConsoleError(() => { });'
⤷ If the error is expected (and asynchronous), use the following pattern at the top of the test:
'expectAsyncConsoleError([, ]);'
```

I think it is because the mocked response object does not support clone, but I might be wrong.

### Reproduction Steps

`amp unit --files=extensions/amp-ad-network-doubleclick-impl/0.1/test/test-amp-ad-network-doubleclick-impl.js` would trigger that.

### Relevant Logs

_No response_

### Browser(s) Affected

_No response_

### OS(s) Affected

_No response_

### Device(s) Affected

_No response_

### AMP Version Affected

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.