ampproject / ampproject/amphtml

[amp-consent]: Orientation changes makes banner half-cut on fullscreen

Open
#35,197 1 comment 0 reactions 0 assignees View on GitHub
Component: amp-consent Stale Type: Bug
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

### Description

When orientation changes on an AMP page with amp-consent component, the CMP banner gets half-cut on fullscreen.

### Reproduction Steps

1) access https://www.google.com/amp/s/www.cio.com/article/3091071/8-things-you-need-to-know-about-google-amp.amp.html
2) once banner appears, click on 'Settings'
3) Change device orientation to landscape
4) See the banner is half cut

### Relevant Logs

_No response_

### Browser(s) Affected

Chrome, Firefox, Safari

### OS(s) Affected

_No response_

### Device(s) Affected

_No response_

### AMP Version Affected

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the amp-consent banner issue at the linked AMP page: open Settings, rotate the device to landscape, and compare Chrome, Firefox, and Safari. Trace the amp-consent component's fullscreen and orientation-change handling; done means the banner remains fully visible after rotation.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.