ampproject / ampproject/amphtml

🏗 🐛 Failed CircleCI workflows show as canceled

Open
#34,743 3 comments 0 reactions 1 assignee Claimed by @rileyajones View on GitHub
Stale Type: Bug WG: infra
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

### Description

When running workflows on CircleCI have been canceling the workflow when any job fails. Unfortunately this results in the workflow being marked as "Canceled" which is misleading as it should really be "Failed".

Example of failed job showing as "Canceled"
![image](https://user-images.githubusercontent.com/78179109/119880595-43d6c600-bee1-11eb-9045-ed7c47bcdf84.png)

### Reproduction Steps

1) Create a pull request on [ampproject/amphtml](https://github.com/ampproject/amphtml) with a step that will fail (automated tests, lint errors, etc).
2) Allow the workflow to run.
3) View the CircleCI workflow and note that the status is canceled.

### Relevant Logs

_No response_

### Browser(s) Affected

_No response_

### OS(s) Affected

_No response_

### Device(s) Affected

_No response_

### AMP Version Affected

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.