ampproject / ampproject/amphtml

[Page attachments] [Inline] `drawer-theme` attribute

Open
#34,464 1 comment 0 reactions 1 assignee Claimed by @raxsha View on GitHub
P3: When Possible Stale Type: Feature Request WG: stories
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

### Description

Currently the drawer `theme` is set to the `theme` on `amp-story-page-attachment`.
This may not work for all designs.

Adding a `drawer-theme` attribute will allow a publisher to specify the theme of the drawer.
It will accept the same values as `theme`.
If not defined it will default to `theme` (current behavior).

This will need to be hidden behind the experiment flag.

Documentation will need to be added to the [I2s](https://github.com/ampproject/amphtml/issues/34449).

@ampproject/wg-stories

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.