ampproject / ampproject/amphtml
[amp-story-player] Audit public API methods for layout state
Open
Stale
Type: Bug
WG: stories
- Dominant language
- JavaScript
- Stars
- 14.9k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
We should audit the public methods of the player for layout state.
In #34360, I found that by calling `play()` under certain circumstances (player hidden, and no user scroll), the player can break. We should investigate other [public methods](https://github.com/ampproject/amphtml/blob/main/spec/amp-story-player.md#programmatic-control) to see if they will work correctly (e.g. `show()`, `add()`, etc..).
/cc @ampproject/wg-stories
Contributor guide
Assessment
This issue has not been assessed yet.