ampproject / ampproject/amphtml

[amp story] Flaky visual test for amp-story-tooltip

Open
#34,080 2 comments 1 reaction 1 assignee Claimed by @processprocess View on GitHub
P2: Soon Stale Type: Bug Type: Testing WG: stories
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

[Percy screenshot](https://percy.io/ampproject/amphtml/builds/10131235/changed/570360299?browser=chrome&browser_ids=16&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=320&widths=320)

`updateEmbedStyleEl` in `amp-story-embedded-component` may be getting called and resizing the component causing the flaky diff.

The `amp-twitter` element on page 2 of `amp-story-tooltip.html` is getting resized after a short interval:

![Apr-29-2021 09-04-40](https://user-images.githubusercontent.com/3860311/116555394-55b94f00-a8ca-11eb-8a61-199bad3026cc.gif)

@ampproject/wg-stories

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.