ampproject / ampproject/amphtml
amp-sidebar is breaking the playground, and iframe'd AMP page builders.
- Dominant language
- JavaScript
- Stars
- 14.9k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
A rather critical issue, breaking the AMP playground, and also our AMP page-builder.
[See here](https://playground.amp.dev/#share=PCFET0NUWVBFIGh0bWw+CjxodG1sIOKaoT4KPGhlYWQ+CiAgPG1ldGEgY2hhcnNldD0idXRmLTgiIC8+CiAgPHRpdGxlPk15IEFNUCBQYWdlPC90aXRsZT4KICA8bGluayByZWw9ImNhbm9uaWNhbCIgaHJlZj0ic2VsZi5odG1sIiAvPgogIDxtZXRhIG5hbWU9InZpZXdwb3J0IiBjb250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgiIC8+CiAgPHN0eWxlIGFtcC1ib2lsZXJwbGF0ZT5ib2R5ey13ZWJraXQtYW5pbWF0aW9uOi1hbXAtc3RhcnQgOHMgc3RlcHMoMSxlbmQpIDBzIDEgbm9ybWFsIGJvdGg7LW1vei1hbmltYXRpb246LWFtcC1zdGFydCA4cyBzdGVwcygxLGVuZCkgMHMgMSBub3JtYWwgYm90aDstbXMtYW5pbWF0aW9uOi1hbXAtc3RhcnQgOHMgc3RlcHMoMSxlbmQpIDBzIDEgbm9ybWFsIGJvdGg7YW5pbWF0aW9uOi1hbXAtc3RhcnQgOHMgc3RlcHMoMSxlbmQpIDBzIDEgbm9ybWFsIGJvdGh9QC13ZWJraXQta2V5ZnJhbWVzIC1hbXAtc3RhcnR7ZnJvbXt2aXNpYmlsaXR5OmhpZGRlbn10b3t2aXNpYmlsaXR5OnZpc2libGV9fUAtbW96LWtleWZyYW1lcyAtYW1wLXN0YXJ0e2Zyb217dmlzaWJpbGl0eTpoaWRkZW59dG97dmlzaWJpbGl0eTp2aXNpYmxlfX1ALW1zLWtleWZyYW1lcyAtYW1wLXN0YXJ0e2Zyb217dmlzaWJpbGl0eTpoaWRkZW59dG97dmlzaWJpbGl0eTp2aXNpYmxlfX1ALW8ta2V5ZnJhbWVzIC1hbXAtc3RhcnR7ZnJvbXt2aXNpYmlsaXR5OmhpZGRlbn10b3t2aXNpYmlsaXR5OnZpc2libGV9fUBrZXlmcmFtZXMgLWFtcC1zdGFydHtmcm9te3Zpc2liaWxpdHk6aGlkZGVufXRve3Zpc2liaWxpdHk6dmlzaWJsZX19PC9zdHlsZT48bm9zY3JpcHQ+PHN0eWxlIGFtcC1ib2lsZXJwbGF0ZT5ib2R5ey13ZWJraXQtYW5pbWF0aW9uOm5vbmU7LW1vei1hbmltYXRpb246bm9uZTstbXMtYW5pbWF0aW9uOm5vbmU7YW5pbWF0aW9uOm5vbmV9PC9zdHlsZT48L25vc2NyaXB0PgogIDxzY3JpcHQgYXN5bmMgc3JjPSJodHRwczovL2Nkbi5hbXBwcm9qZWN0Lm9yZy92MC5qcyI+PC9zY3JpcHQ+CiAgPHNjcmlwdCBhc3luYyBjdXN0b20tZWxlbWVudD0iYW1wLXNpZGViYXIiIHNyYz0iaHR0cHM6Ly9jZG4uYW1wcHJvamVjdC5vcmcvdjAvYW1wLXNpZGViYXItMC4xLmpzIj48L3NjcmlwdD4KICA8c2NyaXB0IGFzeW5jIGN1c3RvbS1lbGVtZW50PSJhbXAtYmluZCIgc3JjPSJodHRwczovL2Nkbi5hbXBwcm9qZWN0Lm9yZy92MC9hbXAtYmluZC0wLjEuanMiPjwvc2NyaXB0PgogIDxzdHlsZSBhbXAtY3VzdG9tPgpoMSB7Cm1hcmdpbjogMXJlbTsKfQo8L3N0eWxlPgo8L2hlYWQ+Cgo8Ym9keSBzdHlsZT0icGFkZGluZzogMTBweCI+CgogIDwhLS0gTUlOSU1BTCBleGFtcGxlIC0tPgogIDxhbXAtc2lkZWJhciBpZD0iYW1wLXNpZGViYXIiIGxheW91dD0ibm9kaXNwbGF5Ij4KICAgIDxkaXY+CiAgICAgIFdoZW4gdGhpcyBtZW51IGlzIGNsb3NlZCwgdGhlIGlmcmFtZSByZWZyZXNoZXMgdG8gdGhlIHBhcmVudCBVUkwgKGJyZWFrcyB0aGUgZWRpdG9yKS4KICAgIDwvZGl2PgogIDwvYW1wLXNpZGViYXI+CgogIDxidXR0b24gcm9sZT0iYnV0dG9uIiBvbj0idGFwOmFtcC1zaWRlYmFyLm9wZW4iIHRhYmluZGV4PSIwIj4KICAgIENsaWNrIG1lIHRvIG9wZW4gdGhlIHNpZGViYXIKICA8L2J1dHRvbj4KCiAgPCEtLSBEb2N1bWVudGF0aW9uIC0tPgogIDxwPgogICAgVGhpcyBpcyBhIG1pbmltYWwgZXhhbXBsZSB0byBkb2N1bWVudCBhbiBpc3N1ZSB0aGF0IGFmZmVjdHMgc29tZSBBTVAgcGFnZSBidWlsZGVycy4KICA8L3A+CiAgPHA+CiAgICA8Yj4KICAgICAgQ2xvc2luZyBhbiBBTVAgc2lkZWJhciBlbGVtZW50IHdpbGwgYXV0b21hdGljYWxseSByZWZyZXNoIHRoZSBpZnJhbWUgdG8gdGhlIHBhcmVudCBVUkwuCiAgICA8L2I+CiAgPC9wPgoKPC9ib2R5Pgo8L2h0bWw+).
**Closing an amp-sidebar element is refreshing the editor, breaking it completely.**
This is relatively catastrophic for affected AMP page-builders.
**This affects the official AMP-playground, and all the AMP-playground examples which include amp-sidebar.**
Tested from Chrome (incognito) and Edge.
Is this happening for anyone else in the [example provided](https://playground.amp.dev/#share=PCFET0NUWVBFIGh0bWw+CjxodG1sIOKaoT4KPGhlYWQ+CiAgPG1ldGEgY2hhcnNldD0idXRmLTgiIC8+CiAgPHRpdGxlPk15IEFNUCBQYWdlPC90aXRsZT4KICA8bGluayByZWw9ImNhbm9uaWNhbCIgaHJlZj0ic2VsZi5odG1sIiAvPgogIDxtZXRhIG5hbWU9InZpZXdwb3J0IiBjb250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgiIC8+CiAgPHN0eWxlIGFtcC1ib2lsZXJwbGF0ZT5ib2R5ey13ZWJraXQtYW5pbWF0aW9uOi1hbXAtc3RhcnQgOHMgc3RlcHMoMSxlbmQpIDBzIDEgbm9ybWFsIGJvdGg7LW1vei1hbmltYXRpb246LWFtcC1zdGFydCA4cyBzdGVwcygxLGVuZCkgMHMgMSBub3JtYWwgYm90aDstbXMtYW5pbWF0aW9uOi1hbXAtc3RhcnQgOHMgc3RlcHMoMSxlbmQpIDBzIDEgbm9ybWFsIGJvdGg7YW5pbWF0aW9uOi1hbXAtc3RhcnQgOHMgc3RlcHMoMSxlbmQpIDBzIDEgbm9ybWFsIGJvdGh9QC13ZWJraXQta2V5ZnJhbWVzIC1hbXAtc3RhcnR7ZnJvbXt2aXNpYmlsaXR5OmhpZGRlbn10b3t2aXNpYmlsaXR5OnZpc2libGV9fUAtbW96LWtleWZyYW1lcyAtYW1wLXN0YXJ0e2Zyb217dmlzaWJpbGl0eTpoaWRkZW59dG97dmlzaWJpbGl0eTp2aXNpYmxlfX1ALW1zLWtleWZyYW1lcyAtYW1wLXN0YXJ0e2Zyb217dmlzaWJpbGl0eTpoaWRkZW59dG97dmlzaWJpbGl0eTp2aXNpYmxlfX1ALW8ta2V5ZnJhbWVzIC1hbXAtc3RhcnR7ZnJvbXt2aXNpYmlsaXR5OmhpZGRlbn10b3t2aXNpYmlsaXR5OnZpc2libGV9fUBrZXlmcmFtZXMgLWFtcC1zdGFydHtmcm9te3Zpc2liaWxpdHk6aGlkZGVufXRve3Zpc2liaWxpdHk6dmlzaWJsZX19PC9zdHlsZT48bm9zY3JpcHQ+PHN0eWxlIGFtcC1ib2lsZXJwbGF0ZT5ib2R5ey13ZWJraXQtYW5pbWF0aW9uOm5vbmU7LW1vei1hbmltYXRpb246bm9uZTstbXMtYW5pbWF0aW9uOm5vbmU7YW5pbWF0aW9uOm5vbmV9PC9zdHlsZT48L25vc2NyaXB0PgogIDxzY3JpcHQgYXN5bmMgc3JjPSJodHRwczovL2Nkbi5hbXBwcm9qZWN0Lm9yZy92MC5qcyI+PC9zY3JpcHQ+CiAgPHNjcmlwdCBhc3luYyBjdXN0b20tZWxlbWVudD0iYW1wLXNpZGViYXIiIHNyYz0iaHR0cHM6Ly9jZG4uYW1wcHJvamVjdC5vcmcvdjAvYW1wLXNpZGViYXItMC4xLmpzIj48L3NjcmlwdD4KICA8c2NyaXB0IGFzeW5jIGN1c3RvbS1lbGVtZW50PSJhbXAtYmluZCIgc3JjPSJodHRwczovL2Nkbi5hbXBwcm9qZWN0Lm9yZy92MC9hbXAtYmluZC0wLjEuanMiPjwvc2NyaXB0PgogIDxzdHlsZSBhbXAtY3VzdG9tPgpoMSB7Cm1hcmdpbjogMXJlbTsKfQo8L3N0eWxlPgo8L2hlYWQ+Cgo8Ym9keSBzdHlsZT0icGFkZGluZzogMTBweCI+CgogIDwhLS0gTUlOSU1BTCBleGFtcGxlIC0tPgogIDxhbXAtc2lkZWJhciBpZD0iYW1wLXNpZGViYXIiIGxheW91dD0ibm9kaXNwbGF5Ij4KICAgIDxkaXY+CiAgICAgIFdoZW4gdGhpcyBtZW51IGlzIGNsb3NlZCwgdGhlIGlmcmFtZSByZWZyZXNoZXMgdG8gdGhlIHBhcmVudCBVUkwgKGJyZWFrcyB0aGUgZWRpdG9yKS4KICAgIDwvZGl2PgogIDwvYW1wLXNpZGViYXI+CgogIDxidXR0b24gcm9sZT0iYnV0dG9uIiBvbj0idGFwOmFtcC1zaWRlYmFyLm9wZW4iIHRhYmluZGV4PSIwIj4KICAgIENsaWNrIG1lIHRvIG9wZW4gdGhlIHNpZGViYXIKICA8L2J1dHRvbj4KCiAgPCEtLSBEb2N1bWVudGF0aW9uIC0tPgogIDxwPgogICAgVGhpcyBpcyBhIG1pbmltYWwgZXhhbXBsZSB0byBkb2N1bWVudCBhbiBpc3N1ZSB0aGF0IGFmZmVjdHMgc29tZSBBTVAgcGFnZSBidWlsZGVycy4KICA8L3A+CiAgPHA+CiAgICA8Yj4KICAgICAgQ2xvc2luZyBhbiBBTVAgc2lkZWJhciBlbGVtZW50IHdpbGwgYXV0b21hdGljYWxseSByZWZyZXNoIHRoZSBpZnJhbWUgdG8gdGhlIHBhcmVudCBVUkwuCiAgICA8L2I+CiAgPC9wPgoKPC9ib2R5Pgo8L2h0bWw+)?
Contributor guide
Assessment
This issue has not been assessed yet.