ampproject / ampproject/amphtml
Add a visual diff test for amp-ad-custom
Open
Stale
Type: Feature Request
- Dominant language
- JavaScript
- Stars
- 14.9k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
In light of https://github.com/ampproject/amphtml/issues/33317 broke amp-ad-custom's template rendering, we will add a visual diff test for amp-ad-custom to prevent similar incidents from reoccurring.
Contributor guide
Research direction
Start by reviewing issue 33317 and the existing amp-ad-custom rendering behavior, then locate the repository's visual diff test entry point and comparable component tests. Add coverage for amp-ad-custom's template rendering and confirm the visual diff catches the regression described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100