ampproject / ampproject/amphtml

Some image resources for e2e tests are missing

Open
#33,308 1 comment 0 reactions 1 assignee Claimed by @micajuine-ho View on GitHub
Stale Type: Bug
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

I.e. in `test/fixtures/e2e/amp-lightbox/amp-lightbox-gallery-launch.amp.html`, we have
```

```

However, the relative path `"./img/lemonyellowgradient.png"` does not exist. I wonder why this isn't getting caught by any tests?

I wonder how difficult it would be to create a presubmit check that ensured that relative paths in e2e fixtures were not deadlinks.

/cc @rileyajones

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.